PHP 8.5 | Fix another runtime deprecation notice #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes yet another "Using null as an array offset" deprecation notice on PHP 8.5. This one only occurred on PHPCS 4.0, not on 3.x. The tests for this fix have been pulled in 1225 (to safeguard that the issue doesn't exist in 3.x) and merged up into the 4.x branch. Note: as the `if` condition was pretty complex, I've done a small refactor to make the code more readable and understandable.
jrfnl
deleted the
phpcs-4.x/feature/fix-another-php-8.5-runtime-deprecation
branch
This was referenced Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #1225
This fixes yet another "Using null as an array offset" deprecation notice on PHP 8.5. This one only occurred on PHPCS 4.0, not on 3.x.
The tests for this fix have been pulled in #1225 (to safeguard that the issue doesn't exist in 3.x) and merged up into the 4.x branch.
Note: as the
ifcondition was pretty complex, I've done a small refactor to make the code more readable and understandable.Suggested changelog entry
Fixed PHP 8.5 "Using null as an array offset" deprecation notice.
Related issues/external references
Loosely related to #1215 and #1216, but yet another instance of this.