Always display timing after run, except when in quiet mode #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoprimo
approved these changes
Apr 16, 2025
jrfnl
force-pushed
the
phpcs-4.0/feature/sq-1612-stdout-vs-stderr
branch
from
a78b0dd to
c3fc316
Compare
jrfnl
force-pushed
the
phpcs-4.0/feature/sq-1612-stdout-vs-stderr
branch
4 times, most recently
from
547a345 to
93ce29b
Compare
Base automatically changed from
phpcs-4.0/feature/sq-1612-stdout-vs-stderr
to
4.x
April 17, 2025 13:09
What with the Timing output now going to `STDERR`, we no longer need to be concerned about the Timing output ending up in `json`, `csv` or `xml` reports (to name a few). In effect, this means, we can now always display Timing and memory usage info at the end of the run. I'm making one exception though: timing will not be displayed when running in `quiet` mode. Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
jrfnl
force-pushed
the
phpcs-4.0/feature/always-display-runtime-info
branch
from
173b62a to
7a24e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What with the Timing output now going to
STDERR, we no longer need to be concerned about the Timing output ending up injson,csvorxmlreports (to name a few).In effect, this means, we can now always display Timing and memory usage info at the end of the run.
I'm making one exception though: timing will not be displayed when running in
quietmode.Suggested changelog entry
Add to changelog entry for STDERR change:
- With this change in place, timing and memory consumption stats will now be displayed more often as it won't interfere with reports.