-
-
Notifications
You must be signed in to change notification settings - Fork 81
Comparing changes
Open a pull request
base repository: PHPCSStandards/PHP_CodeSniffer
base: 1b71b4d
head repository: PHPCSStandards/PHP_CodeSniffer
compare: 5b5e382
- 15 commits
- 15 files changed
- 3 contributors
Commits on Jun 12, 2025
-
The GPG key expires every year - as per the recommendation, so a new key has been generated and uploaded to the openpgp database.
Configuration menu - View commit details
-
Copy full SHA for 5296666 - Browse repository at this point
Copy the full SHA 5296666View commit details
Commits on Jun 13, 2025
-
Release checklist: improve information about regenerating the GPG key
Ran into some issues while trying to do this earlier today. Documenting my findings to prevent the same issues when having to do it again next year. I've also asked a question about key rotation in the PHIVE repo to get clarification on some things: phar-io/phar.io 147. This may result in a new PHIVE documentation page about this being available by next year 🤞 It is also the reason why I have not explicitly released the `3.13.1` tag yet as the README does not contain information about the updated GPG key yet. By rights the new key should probably also be mentioned in the changelog, but tags should be immutable, so I'm going to leave that for now. Hopefully this change in the release checklist will prevent this snafu for next year.
Configuration menu - View commit details
-
Copy full SHA for deb36e2 - Browse repository at this point
Copy the full SHA deb36e2View commit details -
Merge pull request #1130 from PHPCSStandards/feature/update-gpg-key-info
Update for new GPG keys
Configuration menu - View commit details
-
Copy full SHA for 5b7cf79 - Browse repository at this point
Copy the full SHA 5b7cf79View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef0b6a6 - Browse repository at this point
Copy the full SHA ef0b6a6View commit details -
Filter/Filter: remove outdated code that is no longer needed
This commit removes an if condition to maintain backwards compatibility that is no longer needed. It was added via squizlabs/PHP_CodeSniffer@4982619 to preserve backwards compatibility back in a time when it was possible to programmatically set ignore patterns using `CodeSniffer::setIgnorePatterns()` (see https://pear.php.net/bugs/bug.php?id=19859). This method was removed a long time ago via f61025c#diff-c36ecedca179eab0b3cd245e872a96ab26fa08e567437e167f4eda1779c15c89L431-L435, and since then, there is no way for users to set the ignore pattern array with numeric indices.
Configuration menu - View commit details
-
Copy full SHA for ad9a0b2 - Browse repository at this point
Copy the full SHA ad9a0b2View commit details
Commits on Jun 14, 2025
-
Merge pull request #1133 from rodrigoprimo/remove-outdated-code-from-…
…filter-class Filter/Filter: remove outdated code that is no longer needed
Configuration menu - View commit details
-
Copy full SHA for 6739594 - Browse repository at this point
Copy the full SHA 6739594View commit details
Commits on Jun 15, 2025
-
Configuration menu - View commit details
-
Copy full SHA for b128c59 - Browse repository at this point
Copy the full SHA b128c59View commit details
Commits on Jun 17, 2025
-
Squiz/FunctionDeclarationArgumentSpacing: fix typo in `SpacingAfterSe…
…tVis[i]bility` error code The `SpacingAfterVis[i]bility` error code was introduced in v 3.12.0 (March this year) for constructor property promotion. The `SpacingAfterSetVis[i]bility` error code was introduced in v 3.13.1 (few days ago) for constructor property promotion with asym visibility. Both contained the same typo. Now, changing an error code is a breaking change. However, with 3.13.1 only having been released a few days ago, it is my opinion that if released soon as 3.13.2, this is an acceptable bug fix. But then, it would be really weird to not fix the other error code in the same version. Then again, as PHPCS 4.0.0 is around the corner and does allow for breaking changes, let's leave the older typo for 4.0.0, just to be on the safe side.
Configuration menu - View commit details
-
Copy full SHA for a1c2aaa - Browse repository at this point
Copy the full SHA a1c2aaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8ace30 - Browse repository at this point
Copy the full SHA d8ace30View commit details -
Merge pull request #1134 from PHPCSStandards/feature/update-license-c…
…opyright Licence: update copyright
Configuration menu - View commit details
-
Copy full SHA for 47fdb33 - Browse repository at this point
Copy the full SHA 47fdb33View commit details -
Merge pull request #1135 from PHPCSStandards/feature/squiz-functionde…
…clarationargumentspacing-fix-errorcode Squiz/FunctionDeclarationArgumentSpacing: fix typo in `SpacingAfterSetVis[i]bility` error code
Configuration menu - View commit details
-
Copy full SHA for c43b854 - Browse repository at this point
Copy the full SHA c43b854View commit details -
Merge pull request #1137 from PHPCSStandards/feature/docs-various-fixes
Various minor fixes / typos
Configuration menu - View commit details
-
Copy full SHA for 3a9a4b2 - Browse repository at this point
Copy the full SHA 3a9a4b2View commit details -
Squiz/SelfMemberReference: update XML doc (#1108)
- Improve sniff description explicitly mentioning where the spaces are checked and adding context as to when the `self` keyword is verified. - Fix the code examples for checking `self` case and spaces around the double colon to ensure they trigger the sniff (the sniff checks if the call is made within a class). - Improve the titles of the code examples related to spacing around double colons. - Remove unnecessary methods from the code examples related to using `self` instead of the class name when referencing a static member.
Configuration menu - View commit details
-
Copy full SHA for 7af44a3 - Browse repository at this point
Copy the full SHA 7af44a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e1bf44 - Browse repository at this point
Copy the full SHA 5e1bf44View commit details -
Merge pull request #1139 from PHPCSStandards/feature/changelog-3.13.2
Changelog for the 3.13.2 release
Configuration menu - View commit details
-
Copy full SHA for 5b5e382 - Browse repository at this point
Copy the full SHA 5b5e382View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1b71b4d...5b5e382