Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PHPCSStandards/PHP_CodeSniffer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1b71b4d
Choose a base ref
...
head repository: PHPCSStandards/PHP_CodeSniffer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5b5e382
Choose a head ref
  • 15 commits
  • 15 files changed
  • 3 contributors

Commits on Jun 12, 2025

  1. Update for new GPG keys

    The GPG key expires every year - as per the recommendation, so a new key has been generated and uploaded to the openpgp database.
    jrfnl committed Jun 12, 2025
    Configuration menu
    Copy the full SHA
    5296666 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2025

  1. Release checklist: improve information about regenerating the GPG key

    Ran into some issues while trying to do this earlier today. Documenting my findings to prevent the same issues when having to do it again next year.
    I've also asked a question about key rotation in the PHIVE repo to get clarification on some things: phar-io/phar.io 147. This may result in a new PHIVE documentation page about this being available by next year 🤞
    
    It is also the reason why I have not explicitly released the `3.13.1` tag yet as the README does not contain information about the updated GPG key yet.
    
    By rights the new key should probably also be mentioned in the changelog, but tags should be immutable, so I'm going to leave that for now. Hopefully this change in the release checklist will prevent this snafu for next year.
    jrfnl committed Jun 13, 2025
    Configuration menu
    Copy the full SHA
    deb36e2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1130 from PHPCSStandards/feature/update-gpg-key-info

    Update for new GPG keys
    jrfnl authored Jun 13, 2025
    Configuration menu
    Copy the full SHA
    5b7cf79 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef0b6a6 View commit details
    Browse the repository at this point in the history
  4. Filter/Filter: remove outdated code that is no longer needed

    This commit removes an if condition to maintain backwards compatibility
    that is no longer needed. It was added via squizlabs/PHP_CodeSniffer@4982619
    to preserve backwards compatibility back in a time when it was possible
    to programmatically set ignore patterns using
    `CodeSniffer::setIgnorePatterns()` (see https://pear.php.net/bugs/bug.php?id=19859).
    This method was removed a long time ago via f61025c#diff-c36ecedca179eab0b3cd245e872a96ab26fa08e567437e167f4eda1779c15c89L431-L435,
    and since then, there is no way for users to set the ignore pattern
    array with numeric indices.
    rodrigoprimo committed Jun 13, 2025
    Configuration menu
    Copy the full SHA
    ad9a0b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2025

  1. Merge pull request #1133 from rodrigoprimo/remove-outdated-code-from-…

    …filter-class
    
    Filter/Filter: remove outdated code that is no longer needed
    jrfnl authored Jun 14, 2025
    Configuration menu
    Copy the full SHA
    6739594 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2025

  1. Licence: update copyright

    jrfnl committed Jun 15, 2025
    Configuration menu
    Copy the full SHA
    b128c59 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2025

  1. Squiz/FunctionDeclarationArgumentSpacing: fix typo in `SpacingAfterSe…

    …tVis[i]bility` error code
    
    The `SpacingAfterVis[i]bility` error code was introduced in v 3.12.0 (March this year) for constructor property promotion.
    The `SpacingAfterSetVis[i]bility` error code was introduced in v 3.13.1 (few days ago) for constructor property promotion with asym visibility.
    
    Both contained the same typo.
    
    Now, changing an error code is a breaking change. However, with 3.13.1 only having been released a few days ago, it is my opinion that if released soon as 3.13.2, this is an acceptable bug fix.
    But then, it would be really weird to not fix the other error code in the same version. Then again, as PHPCS 4.0.0 is around the corner and does allow for breaking changes, let's leave the older typo for 4.0.0, just to be on the safe side.
    jrfnl committed Jun 17, 2025
    Configuration menu
    Copy the full SHA
    a1c2aaa View commit details
    Browse the repository at this point in the history
  2. Various minor fixes / typos

    ... picked up along the way.
    jrfnl committed Jun 17, 2025
    Configuration menu
    Copy the full SHA
    d8ace30 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1134 from PHPCSStandards/feature/update-license-c…

    …opyright
    
    Licence: update copyright
    jrfnl authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    47fdb33 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1135 from PHPCSStandards/feature/squiz-functionde…

    …clarationargumentspacing-fix-errorcode
    
    Squiz/FunctionDeclarationArgumentSpacing: fix typo in `SpacingAfterSetVis[i]bility` error code
    jrfnl authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    c43b854 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1137 from PHPCSStandards/feature/docs-various-fixes

    Various minor fixes / typos
    jrfnl authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    3a9a4b2 View commit details
    Browse the repository at this point in the history
  6. Squiz/SelfMemberReference: update XML doc (#1108)

    - Improve sniff description explicitly mentioning where the spaces are
    checked and adding context as to when the `self` keyword is verified.
    - Fix the code examples for checking `self` case and spaces around the
    double colon to ensure they trigger the sniff (the sniff checks if the
    call is made within a class).
    - Improve the titles of the code examples related to spacing around
    double colons.
    - Remove unnecessary methods from the code examples related to using
    `self` instead of the class name when referencing a static member.
    rodrigoprimo authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    7af44a3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5e1bf44 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #1139 from PHPCSStandards/feature/changelog-3.13.2

    Changelog for the 3.13.2 release
    jrfnl authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    5b5e382 View commit details
    Browse the repository at this point in the history
Loading