Skip to content

Commit

Permalink
GH Actions: few small workflow tweaks
Browse files Browse the repository at this point in the history
* Remove some information from a step name which is already in a comment above it.
* Fold two steps into one (Composer install).
* Add a missing condition to prevent a step from running when it is not needed.
  • Loading branch information
jrfnl committed Dec 9, 2023
1 parent e844821 commit 5f130d8
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
tools: cs2pr

# This action also handles the caching of the dependencies.
- name: Set up node and enable caching of dependencies
- name: Set up node
uses: actions/setup-node@v4
with:
node-version: '20'
Expand All @@ -125,18 +125,9 @@ jobs:
# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-php-dependencies-with-composer
- name: Install Composer dependencies
if: ${{ matrix.php != '8.4' }}
uses: "ramsey/composer-install@v2"
with:
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

# For PHP "nightly", we install with ignore platform reqs.
- name: Install Composer dependencies - with ignore platform
if: ${{ matrix.php == '8.4' }}
uses: "ramsey/composer-install@v2"
with:
composer-options: --ignore-platform-req=php
composer-options: ${{ matrix.php == '8.4' && '--ignore-platform-req=php' || '' }}
custom-cache-suffix: $(date -u "+%Y-%m")

# Note: The code style check is run multiple times against every PHP version
Expand All @@ -161,6 +152,7 @@ jobs:
run: cs2pr ./phpcs-report.xml

- name: Download the PHPCS phar
if: ${{ matrix.custom_ini == false }}
uses: actions/download-artifact@v3
with:
name: phpcs-phar
Expand Down

0 comments on commit 5f130d8

Please sign in to comment.