CS/QA: remove unused foreach keys from report code

As the array format is now documented, these unused variables are no longer needed for documentation purposes. Co-authored-by: Klaus Purer <klaus.purer@protonmail.ch>
PHPCSStandards · Jul 2, 2024 · 0c345b3 · 0c345b3
1 parent e9762c6
commit 0c345b3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/Reports/Code.php b/src/Reports/Code.php
@@ -119,8 +119,8 @@ public function generateFileReport($report, File $phpcsFile, $showSources=false,
 
         // Determine the longest error message we will be showing.
         $maxErrorLength = 0;
-        foreach ($report['messages'] as $line => $lineErrors) {
-            foreach ($lineErrors as $column => $colErrors) {
+        foreach ($report['messages'] as $lineErrors) {
+            foreach ($lineErrors as $colErrors) {
                 foreach ($colErrors as $error) {
                     $length = strlen($error['message']);
                     if ($showSources === true) {
@@ -262,7 +262,7 @@ public function generateFileReport($report, File $phpcsFile, $showSources=false,
 
             echo str_repeat('-', $width).PHP_EOL;
 
-            foreach ($lineErrors as $column => $colErrors) {
+            foreach ($lineErrors as $colErrors) {
                 foreach ($colErrors as $error) {
                     $padding = ($maxLineNumLength - strlen($line));
                     echo 'LINE '.str_repeat(' ', $padding).$line.': ';

diff --git a/src/Reports/Full.php b/src/Reports/Full.php
@@ -61,8 +61,8 @@ public function generateFileReport($report, File $phpcsFile, $showSources=false,
 
         // Make sure the report width isn't too big.
         $maxErrorLength = 0;
-        foreach ($report['messages'] as $line => $lineErrors) {
-            foreach ($lineErrors as $column => $colErrors) {
+        foreach ($report['messages'] as $lineErrors) {
+            foreach ($lineErrors as $colErrors) {
                 foreach ($colErrors as $error) {
                     // Start with the presumption of a single line error message.
                     $length    = strlen($error['message']);
@@ -138,7 +138,7 @@ public function generateFileReport($report, File $phpcsFile, $showSources=false,
         $beforeAfterLength = strlen($beforeMsg.$afterMsg);
 
         foreach ($report['messages'] as $line => $lineErrors) {
-            foreach ($lineErrors as $column => $colErrors) {
+            foreach ($lineErrors as $colErrors) {
                 foreach ($colErrors as $error) {
                     $errorMsg = wordwrap(
                         $error['message'],

diff --git a/src/Reports/Source.php b/src/Reports/Source.php
@@ -39,8 +39,8 @@ public function generateFileReport($report, File $phpcsFile, $showSources=false,
 
         $sources = [];
 
-        foreach ($report['messages'] as $line => $lineErrors) {
-            foreach ($lineErrors as $column => $colErrors) {
+        foreach ($report['messages'] as $lineErrors) {
+            foreach ($lineErrors as $colErrors) {
                 foreach ($colErrors as $error) {
                     $src = $error['source'];
                     if (isset($sources[$src]) === false) {

diff --git a/src/Reports/VersionControl.php b/src/Reports/VersionControl.php
@@ -65,7 +65,7 @@ public function generateFileReport($report, File $phpcsFile, $showSources=false,
 
             $praiseCache[$author]['bad']++;
 
-            foreach ($lineErrors as $column => $colErrors) {
+            foreach ($lineErrors as $colErrors) {
                 foreach ($colErrors as $error) {
                     $authorCache[$author]++;