Draft
Conversation
alexander-schranz
added
Require BC Break
alexander-schranz
force-pushed
the
feature/seal-odm
branch
3 times, most recently
from
4dbc038 to
70b97fb
Compare
alexander-schranz
force-pushed
the
feature/seal-odm
branch
from
70b97fb to
bebf856
Compare
alexander-schranz
added a commit
that referenced
this pull request
Mar 23, 2026
) Currently it is not possible to create a reusable ReindexProvider as all ReindexProviders require to implement a static method `public static function getIndex(): string` we should get rid of them so people can create ReindexProviders which are reusable and just configurable by there constructor. This also add possibility to wrap / decorate ReindexProviders easier, which we require for ODM (#81 #661). ## BC Breaks The `ReindexProviderInterface` and `getIndex` method is not longer static and the interface was renamed to `StaticReindexProviderInterface` as in a `DynamicReindexProviderInterface` without getIndexName method will be added in upcoming PR: ```diff -class YourClass implements ReindexProviderInterface { +class YourClass implements StaticReindexProviderInterface { // ... - public static function getIndex(): string + public function getIndexName(): string { return 'test'; } } ``` If you need to support 0.12 and 0.13 the same time you can implement both methods and keep using the deprecated ReindexProviderInterface until 0.14 or 1.0: ```diff class YourClass implements ReindexProviderInterface { // ... public static function getIndex(): string { return 'index'; } + public function getIndexName(): string + { + return self::getIndex(); + } } ``` fixes #615
alexander-schranz
force-pushed
the
feature/seal-odm
branch
2 times, most recently
from
c782233 to
4028bd0
Compare
alexander-schranz
force-pushed
the
feature/seal-odm
branch
from
4028bd0 to
29581bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently prototyping I little around how we can add support to map directly to an object.
The first Idea is to create a
OdmEnginewhich decorates theEngineand uses objects instead of arrays.fixes #81