Fix unreliable unit tests #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeuchler
previously approved these changes
Jan 5, 2026
1nf0rmagician
force-pushed
the
fix/unit-test-unreliabilities
branch
from
76e2074 to
214724e
Compare
dbeuchler
previously approved these changes
Jan 5, 2026
- Properly time simulation test for completed activity movement when the activity is already running - Add missing logger in tests using the JobHandler - Increase reliability of time sensitive tests of the `ModuleManager.Start` methods, by adding time-boxed waiting for longer periods
1nf0rmagician
force-pushed
the
fix/unit-test-unreliabilities
branch
from
214724e to
a5a17ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ModuleManager.Startmethods, by adding time-boxed waiting for longer periods