Skip to content

Conversation

@dbeuchler
Copy link
Member

@dbeuchler dbeuchler commented Dec 15, 2025

closes #927

@1nf0rmagician Question: One Amount-Reached notification for all operations (if there is any), or as before, each separately? Does it make sense to have more than one?

@dbeuchler dbeuchler added this to the Framework 10.0.0 milestone Dec 15, 2025
@dbeuchler dbeuchler self-assigned this Dec 15, 2025
@dbeuchler dbeuchler added the enhancement New feature or request label Dec 15, 2025
@dbeuchler dbeuchler force-pushed the feature/operation-notifications branch 2 times, most recently from 984dd3e to 744abc2 Compare December 15, 2025 19:37
@dbeuchler dbeuchler force-pushed the feature/operation-notifications branch from 744abc2 to e72a586 Compare December 15, 2025 19:38
@1nf0rmagician
Copy link
Member

To make life easy for users I would add the information which order has reached the target amount, i.e. not just "Some order has reached the target amount".

If that is in one notification that is updated on changes or in separate once I don't have a strong opinion on. @dacky179 any opinion on that?

@dacky179
Copy link
Member

dacky179 commented Dec 16, 2025

I think one notification for each single operation is better:

  • Code is more easy
  • Notifications shown in the Dashboard will be countable. i.e. a combined notification for all would lead to one event shown multiple times in the dashboard: O1 amount reached -> O1 and O2 amount reached -> O2 amount reached.
  • for vertical integration it would be nice to have a action when selecting the notification; i.e. like jump to ordermanagement with selected operation to complete. This would be more difficult if its multiple.

@dbeuchler
Copy link
Member Author

Okay, then I will integrate it as before. One Notification for each Operation.

@dbeuchler dbeuchler marked this pull request as ready for review December 16, 2025 13:27
@dbeuchler dbeuchler force-pushed the feature/operation-notifications branch from 4953945 to 191c760 Compare December 16, 2025 14:22
@dbeuchler dbeuchler merged commit 04e0546 into future Jan 5, 2026
8 checks passed
@dbeuchler dbeuchler deleted the feature/operation-notifications branch January 5, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants