Fix RecipeAssignStep recreate job on product type changed #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DosenSuppe
added
bug
1nf0rmagician
requested changes
Dec 11, 2025
src/Moryx.Orders.Management/Implementation/Assignment/RecipeAssignStep.cs
Outdated
Show resolved
Hide resolved
DosenSuppe
force-pushed
the
port/FixRecipeAssignmentStepToFuture
branch
from
3888548 to
d6b65c9
Compare
1nf0rmagician
force-pushed
the
port/FixRecipeAssignmentStepToFuture
branch
from
d6b65c9 to
d1f61ce
Compare
dbeuchler
reviewed
Jan 6, 2026
src/Moryx.Orders.Management/Implementation/Assignment/RecipeAssignStep.cs
Outdated
Show resolved
Hide resolved
src/Moryx.Orders.Management/Implementation/Assignment/RecipeAssignStep.cs
Outdated
Show resolved
Hide resolved
src/Moryx.Orders.Management/Implementation/Assignment/RecipeAssignStep.cs
Outdated
Show resolved
Hide resolved
1nf0rmagician
force-pushed
the
port/FixRecipeAssignmentStepToFuture
branch
from
d1f61ce to
f3cc219
Compare
1nf0rmagician
force-pushed
the
port/FixRecipeAssignmentStepToFuture
branch
from
f3cc219 to
28bd126
Compare
dbeuchler
reviewed
Jan 7, 2026
src/Moryx.Orders.Management/Implementation/Assignment/RecipeAssignStep.cs
Outdated
Show resolved
Hide resolved
src/Moryx.Orders.Management/Implementation/Assignment/RecipeAssignStep.cs
Outdated
Show resolved
Hide resolved
1nf0rmagician
force-pushed
the
port/FixRecipeAssignmentStepToFuture
branch
from
28bd126 to
1063925
Compare
Changed product type must not lead to a direct recreate of the job. Check referenced products recursive. Unregister events correctly.
1nf0rmagician
force-pushed
the
port/FixRecipeAssignmentStepToFuture
branch
from
1063925 to
794344f
Compare
1nf0rmagician
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
RecipeAssignStep recreates job upon changing the product type.
Solution:
References products are checked recursively.
Also unregister events correctly.
(cherry picked from commit 733c72ab9b85e901fa7ed5836aed61282d4d9629)