fix/EntryConvert_ParseWithFallback#1224
Open
H4llJ0rdan wants to merge 4 commits into
Open
Conversation
…djusted for new moryx-ngx-web-framework
1nf0rmagician
requested changes
May 20, 2026
Member
1nf0rmagician
left a comment
There was a problem hiding this comment.
I like the change! We don't have to wait on the referenced PR, even though the bug won't be fixed just by this. But as it is a pure enhancement without breaking existing behaviour that is fine.
Only thing, I need to ask you to please check formatting once. With the editorconfig the IDE should tell you several spots to adjust 😬
dbeuchler
reviewed
May 20, 2026
dbeuchler
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found the bug, that floating point properties of resources could not be edited, if the culture was changed to de-DE. Together with PR, this problem should be fixed. May be we should wait for the PR to adujust the version of the ngx-moryx-web package?
Introduced ParseWithFallback for numeric parsing
Replaced direct Parse calls for floating point types
Improved robustness of type conversion