Skip to content

fix/EntryConvert_ParseWithFallback#1224

Open
H4llJ0rdan wants to merge 4 commits into
devfrom
fix/parseWithFallback
Open

fix/EntryConvert_ParseWithFallback#1224
H4llJ0rdan wants to merge 4 commits into
devfrom
fix/parseWithFallback

Conversation

@H4llJ0rdan
Copy link
Copy Markdown
Contributor

We found the bug, that floating point properties of resources could not be edited, if the culture was changed to de-DE. Together with PR, this problem should be fixed. May be we should wait for the PR to adujust the version of the ngx-moryx-web package?

  • Introduced ParseWithFallback for numeric parsing

    • Attempts parsing using the provided culture first
    • Falls back to InvariantCulture if parsing fails
  • Replaced direct Parse calls for floating point types

    • Applied to float, double, and decimal
  • Improved robustness of type conversion

    • Reduces failures caused by culture-specific number formats (e.g. , vs .)
    • Ensures better compatibility for internationalized inputs

@H4llJ0rdan H4llJ0rdan requested a review from 1nf0rmagician May 18, 2026 10:35
@1nf0rmagician 1nf0rmagician added the bug Something isn't working label May 20, 2026
@1nf0rmagician 1nf0rmagician added this to the Framework 10.x milestone May 20, 2026
Copy link
Copy Markdown
Member

@1nf0rmagician 1nf0rmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change! We don't have to wait on the referenced PR, even though the bug won't be fixed just by this. But as it is a pure enhancement without breaking existing behaviour that is fine.

Only thing, I need to ask you to please check formatting once. With the editorconfig the IDE should tell you several spots to adjust 😬

Copy link
Copy Markdown
Member

@dbeuchler dbeuchler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think it i worth to add 1 or 2 tests for this case
  • Maybe a better commit message (you write something about package-lock?)

Comment thread src/Moryx/Serialization/EntryConvert/EntryConvertGenerator.cs Outdated
Comment thread src/Moryx/Serialization/EntryConvert/EntryConvertGenerator.cs Outdated
Comment thread src/Moryx/Serialization/EntryConvert/EntryConvertGenerator.cs Outdated
Copy link
Copy Markdown
Member

@1nf0rmagician 1nf0rmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@H4llJ0rdan H4llJ0rdan changed the title fix/EntryConvert_ParseWithFallback -> check if package-lock must be a… fix/EntryConvert_ParseWithFallback May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants