Allow loading of archived processes by id#1220
Open
1nf0rmagician wants to merge 1 commit into
Open
Conversation
Extend process control facade to access even more (specific) information, the process control facade should be extended, e.g. for accessing an archived process by a given id.
1nf0rmagician
force-pushed
the
port/extend-process-control-facade-to-release/10
branch
from
4e37579 to
2995525
Compare
dbeuchler
approved these changes
May 20, 2026
| where processEntity.Id == id | ||
| select new { processEntity.Id, processEntity.Job.RecipeId, processEntity.ReferenceId }; | ||
|
|
||
| var entity = query.FirstOrDefault(); |
Member
There was a problem hiding this comment.
you can youse FirstOrDefaultAsync here
| /// <summary> | ||
| /// Facade interface to get even more information from the control system | ||
| /// </summary> | ||
| public interface IProcessControlExtended : IProcessControl |
Member
There was a problem hiding this comment.
can you add a TODO here for removing it in MORYX 12?
| namespace Moryx.ControlSystem.ProcessEngine; | ||
|
|
||
| /// <summary> | ||
| /// Facade interface to get even more information from the control system |
Member
There was a problem hiding this comment.
control system -> process engine?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend process control facade to access even more (specific) information, the process control facade should be extended, e.g. for accessing an archived process by a given id.
Checklist for Submitter
Review
Typical tasks
Clean code