Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate scanners #48

Merged
merged 22 commits into from
Oct 19, 2023
Merged

Consolidate scanners #48

merged 22 commits into from
Oct 19, 2023

Conversation

LilaKelland
Copy link
Collaborator

  • Consolidated the scanners.
  • Changed dev environment to node 18 (may need to change this to alpine, and in the Dockerfile rather than json)

Removed:

  • service discovery
  • endpoint dispatcher
  • github octokit repo details, (and the corresponding superfluous functions format the response)

Now:

  • Moved to receive payload from webhook (github-clone-repo and github-octokit-check both subscribe to GitHubEvents) rather than endpoint-dispatcher
  • github-clone-repo still clones repo
  • github-checks-on-cloned repo scans the cloned repo for files and directories (note - feeling like once we have more thorugh scans for api and tests, we'll eliminate those here (ie dependabot.yaml)
  • github-octokit-checks calls to the octokit API to retrieve repo metadata details and information on security protocols implemented.
  • There are couple of checks in github-octokit-checks that require main branch (which can be pulled from githubrepodetails) so either that can be linked, or can be published to a branch check (that this service is subscribed to as well) and be handled that way. Right now blanket passing main branch to all calls, but will need to update this in the future.

Still to do

  • move tests over and create more for better coverage
  • save to db

LilaKelland and others added 22 commits October 16, 2023 14:25
…. Have github-checks-on-cloned-repo working, now need to refactor
… and move to alpine), moving to strategy pattern for octokit - still need to add a few more and extract the call to octokit function
…pp.js - will move to index tomorrow and format branch protection
… token does not have permission to access security information, removed app.js, cleaned up index.js
- production cluster will use mTLS on mesh for all nodes on cluster.
- simplifies local dev environment
@Collinbrown95 Collinbrown95 merged commit 66e7168 into main Oct 19, 2023
@Collinbrown95 Collinbrown95 deleted the consolidate-scanners branch October 25, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants