Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable label translation #26

Closed
wants to merge 1 commit into from
Closed

Enable label translation #26

wants to merge 1 commit into from

Conversation

aloupfor
Copy link
Contributor

@aloupfor aloupfor commented Nov 2, 2018

Hi,

I installed the GDPR module and saw that "Delete my account" and "Download my account data" were not translated (using fr_FR). I was able to enable the translation by adding translate="label".

@bastienlm
Copy link
Contributor

Hi,
you're here 21 hour too late ^^
@mbensoussan already have fix this issue #24
But thanks anyway :)

@bastienlm bastienlm closed this Nov 2, 2018
@aloupfor aloupfor deleted the enable-label-translation branch November 2, 2018 15:17
@aloupfor
Copy link
Contributor Author

aloupfor commented Nov 2, 2018

I made this change with last release in mind.
I did not even saw that translate="label" was already in the lines where I pasted it after that I made a fork.
Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aloupfor @bastienlm