Fix issue #15 #16

README.md

@@ -1,49 +1,45 @@
-# WARNING, this module is in development, you can contribute on develop branch but we do not advise you to use this for the moment in production environment
-
 # PH2M GDPR
 
-Magento 1 module for respect reform of EU data protection rules (GDPR)
+Free Magento 1 module for respect reform of EU data protection rules (GDPR)
 
 
 ## Requirements
 
 - Only test on Magento 1.9.x (but probably work on magento 1.4.x to 1.9.x)
-- Aoe_Scheduler : https://github.com/AOEpeople/Aoe_Scheduler
 
 ## Changelog 
 See RELEASE_NOTES.txt
 
 ## Installation
-Composer : (SOON)
+Composer :
 ```
 composer require ph2m/gdpr
 ```
 Manual :
 Download this module and add 'app' and 'skin' directory to you magento
 
 ## Feature
-- Full manageable, you can enabled / disabled all functionality from your back-office
+**Full manageable, you can enabled / disabled all functionality from your back-office**
 - Download, remove and anonymize customer data
     - Live system: customer can directly download or remove their own data from their dashboard
-    - Queue system: you can enabled queue system for remove or download customer data if you have heavy treatment
+    - [developer only] Queue system: you can enabled queue system for remove or download customer data if you have heavy treatment 
     - Email notification 
 - Extra features 
-    - Enable complex password for respect CNIL recommendation 
-    - Enable login attempt lock after 5 try
+    - Enable complex password for respect [CNIL recommendation](https://www.cnil.fr/fr/authentification-par-mot-de-passe-les-mesures-de-securite-elementaires) 
+    - Enable login attempt lock multi try
 - Check GDPR validity
     - Check if all config for respect GDPR is enabled
-
 - Remove and anonymize customer data:
-    - Remove from newsletter (can be disabled)
-    - Remove customer account (can be disabled)
-    - Remove customer quote (can be disabled)
-    - Anonymize customer order (can be disabled)
-    - Anonymise customer product reviews (can be disabled)
+    - Remove from newsletter
+    - Remove customer account
+    - Remove customer quote
+    - Anonymize customer order
+    - Anonymise customer product reviews
 - Download customer data:
-    - Download customer account data (you can choose attributes to export or disabled)
-    - Download customer addresses data (you can choose attributes to export or disabled)
-    - Download customer orders data (you can choose attributes to export or disabled)
-    - Donwload customer product reviews (can be disabled)
+    - Download customer account data (you can choose attributes to export)
+    - Download customer addresses data (you can choose attributes to export)
+    - Download customer orders data (you can choose attributes to export)
+    - Donwload customer product reviews
 - Manage cookies (with [tarteaucitron.js](https://github.com/AmauriC/tarteaucitron.js))
     - Display cookies consent banner and popup
     - Compatible with magento google analytics (can be disabled)

RELEASE_NOTES.txt

@@ -1,6 +1,5 @@
 ==== 1.0.0 ====
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
 Init module :
 - Create phgdpr/queue table
 - Rewrite Mage_Customer_Model_Customer for add complex password
@@ -10,17 +9,19 @@ Init module :
 - create queue system
 - create download customer data process
 - create clean file process
-==== 1.0.1 ====
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+==== 1.0.1 ====
+
 - Fix bad config Path on layout file
 - Fix bad module name on adminhtml file
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ==== 1.1.0 ====
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
 - [Feature] Add customer product reviews to download date and remove date
 - [Feature] Add cookies management with tarteaucitron
+- [Feature Update] Login attempt
+- [Fix] #11 #9 #13 #15
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

app/code/community/PH2M/Gdpr/Helper/Password.php

@@ -26,7 +26,7 @@ class PH2M_Gdpr_Helper_Password
      */
     public function invalidPasswordFormat($password)
     {
-        $errorCount = 0;
+        $errorCount = 1;
         if (strlen($password) < '8') {
             return Mage::helper('phgdpr')->__('Your password must contain at least 8 characters.');
         }

app/code/community/PH2M/Gdpr/Model/Observer.php

@@ -19,7 +19,7 @@ class PH2M_Gdpr_Model_Observer
     protected $configModel;
     const EXCEPTION_ACCOUNT_GDPR_LOCK = 20;
     const DEFAULT_ATTEMPS_NUMBER = 5;
-    const DEFAULT_TIME_BLOCKED = 1;
+    const DEFAULT_TIME_BLOCKED = 5;
 
 
     /**

app/design/frontend/base/default/template/ph/gdpr/download.phtml

@@ -24,7 +24,7 @@
     <form action="<?php echo Mage::helper('phgdpr')->getDownloadAccountDataUrl() ?>" method="POST">
         <button type="submit" class="button">
             <span>
-                <?php echo $this->__('Download your account information') ?>
+                <?php echo $this->__('Download my account data') ?>
             </span>
         </button>
     </form>

app/locale/fr_FR/PH2M_Gdpr.csv

@@ -60,7 +60,7 @@
 "Wording personalize button","Libellé du bouton personnaliser"
 "Enable Google Analytics service","Activer le service Google Analytics"
 "Attempts number","Nombre de tentative"
-"default value, 5 try","valeur par défault, 5 tentative"
+"default value, 5 try","valeur par défault, 5 tentatives"
 "Time blocked","Temps de blocage"
 "in minutes, default value 5 minutes","En minutes, valeur par défaut 5 minutes"
 #############