Add is_custom_device to support metax-gpu #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeingGod
reviewed
Sep 12, 2025
| } | ||
|
|
||
| if (inp_features.is_gpu()) { | ||
| if (inp_features.is_gpu() || inp_features.is_custom_device()) { |
Collaborator
There was a problem hiding this comment.
对于非cuda兼容的 custom device 设备，不应该走到 CUDA kernel
Collaborator
|
@yuchunliu-metax 这里是否可以暂时改成通过类似 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
metax-gpu 在paddle 3.0 框架下走的是custom_device 分支，因此在Open3D中需要增加 is_custom_device支持metax-gpu。