Feature reinitialization cases. Closes #30#35
Merged
LeonardSchmiester merged 5 commits intodevelopfrom Nov 26, 2020
Merged
Conversation
Author
|
Might be good to also add a case similar to 10, just with the init parameters instead of the species in the condition table?! |
dweindl
reviewed
Nov 25, 2020
petabtests/cases/0017/0017.md
Outdated
| For preequilibration, species `B` is initialized with `0`. For simulation, | ||
| `B` is set to `NaN`, meaning that it is initialized with the result from | ||
| preequilibration. | ||
| For `A` the preequilibration result is to be used. |
Member
There was a problem hiding this comment.
What about changing the test to reinitializing A (and continuing B) to ensure, that not just everything is continued from steadystate if there is a NaN somewhere? Looks good otherwise, thanks.
Author
There was a problem hiding this comment.
Sounds good. I changed it accordingly.
added 2 commits
November 26, 2020 10:21
yannikschaelte
approved these changes
Nov 26, 2020
Member
yannikschaelte
left a comment
yannikschaelte
left a comment
There was a problem hiding this comment.
Looks good to me. Maybe change target to develop as a test gets changed and one added, and discuss to update the test suite in the next PEtab meeting?
dweindl
added a commit
to AMICI-dev/AMICI
that referenced
this pull request
Feb 18, 2021
…fixes (#1417) Adds possibility to provide state indices for selective reinitialization based on fixed parameters. The previous `ExpData::reinitializeFixedParameterInitialStates` is still there, but will be removed in an upcoming version. Addresses #1345, #1396, #1319 Supersedes #1344 Include new test cases from PEtab-dev/petab_test_suite#35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a Case for
NaN's in the condition table. Also changed Case 10 to have different values for preeq and sim conditions for speciesBas the previous implementation did not catch all cases, where reinitialization did not work properly (see AMICI-dev/AMICI#1319).