Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vis: Fix cropped errorbars #99

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Vis: Fix cropped errorbars #99

merged 1 commit into from
Dec 1, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 30, 2021

Remove matplotlib.axes.Axes.relim which ignores error bars ("At present, Collection instances are not supported.")

Fixes #74

Remove [matplotlib.axes.Axes.relim](https://matplotlib.org/stable/api/_as_gen/matplotlib.axes.Axes.relim.html) which ignores error bars ("At present, Collection instances are not supported.")

Fixes #74
@dweindl dweindl requested a review from plakrisenko November 30, 2021 22:22
@codecov-commenter
Copy link

Codecov Report

Merging #99 (9dd2a82) into develop (9c8c72e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #99      +/-   ##
===========================================
- Coverage    79.95%   79.95%   -0.01%     
===========================================
  Files           27       27              
  Lines         2979     2978       -1     
  Branches       722      722              
===========================================
- Hits          2382     2381       -1     
  Misses         419      419              
  Partials       178      178              
Impacted Files Coverage Δ
petab/visualize/plotter.py 77.24% <ø> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8c72e...9dd2a82. Read the comment docs.

@plakrisenko plakrisenko linked an issue Dec 1, 2021 that may be closed by this pull request
@plakrisenko plakrisenko merged commit 1e166ec into develop Dec 1, 2021
@dweindl dweindl deleted the fix_74 branch December 1, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualization: cropped error bars
3 participants