Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line interface for plotting #98

Merged
merged 8 commits into from
Nov 30, 2021
Merged

Add command line interface for plotting #98

merged 8 commits into from
Nov 30, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 30, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #98 (171115e) into develop (7c5305a) will increase coverage by 0.06%.
The diff coverage is 76.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
+ Coverage    79.85%   79.91%   +0.06%     
===========================================
  Files           26       27       +1     
  Lines         2953     2978      +25     
  Branches       719      722       +3     
===========================================
+ Hits          2358     2380      +22     
  Misses         420      420              
- Partials       175      178       +3     
Impacted Files Coverage Δ
petab/visualize/cli.py 76.00% <76.00%> (ø)
petab/visualize/plotting.py 86.19% <0.00%> (+0.33%) ⬆️
petab/visualize/plot_data_and_simulation.py 85.29% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5305a...171115e. Read the comment docs.

@dweindl dweindl requested a review from dilpath November 30, 2021 16:32
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Could add a cell to a notebook to show how the same plot can be generated with either Python code or this CLI

petab/visualize/cli.py Outdated Show resolved Hide resolved
petab/visualize/cli.py Outdated Show resolved Hide resolved
Comment on lines +25 to +27
parser.add_argument('--style', required=False,
dest='style_file_name',
help='Matplotlib style file')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, adding an example at some point to show how Seaborn defaults could be used could be helpful

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g., --style seaborn-colorblind

petab/visualize/cli.py Outdated Show resolved Hide resolved
petab/visualize/cli.py Outdated Show resolved Hide resolved
petab/visualize/cli.py Outdated Show resolved Hide resolved
petab/visualize/cli.py Outdated Show resolved Hide resolved
dweindl and others added 3 commits November 30, 2021 17:55
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@dweindl
Copy link
Member Author

dweindl commented Nov 30, 2021

Could add a cell to a notebook to show how the same plot can be generated with either Python code or this CLI

Agreed. Will keep that for after #89 (notebooks are currently failing).

@dweindl dweindl marked this pull request as ready for review November 30, 2021 17:44
@dweindl dweindl merged commit 9c8c72e into develop Nov 30, 2021
@dweindl dweindl deleted the vis_cli branch November 30, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants