-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command line interface for plotting #98
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
+ Coverage 79.85% 79.91% +0.06%
===========================================
Files 26 27 +1
Lines 2953 2978 +25
Branches 719 722 +3
===========================================
+ Hits 2358 2380 +22
Misses 420 420
- Partials 175 178 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Could add a cell to a notebook to show how the same plot can be generated with either Python code or this CLI
parser.add_argument('--style', required=False, | ||
dest='style_file_name', | ||
help='Matplotlib style file') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, adding an example at some point to show how Seaborn defaults could be used could be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g., --style seaborn-colorblind
Agreed. Will keep that for after #89 (notebooks are currently failing). |
No description provided.