-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pathlib for reading PEtab tables #93
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #93 +/- ##
===========================================
+ Coverage 79.65% 79.70% +0.04%
===========================================
Files 26 26
Lines 2935 2941 +6
Branches 709 709
===========================================
+ Hits 2338 2344 +6
Misses 422 422
Partials 175 175
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Maybe nice to define e.g. petab.C.TYPE_PATH = Union[str, Path]
, could make the type hints a little neater. Not sure if it can be used as isinstance(..., TYPE_PATH)
though.
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Does not look very neat, agreed. Briefly thought about it, but then decided that it might be more convenient to users to directly have the types there, without looking up what the other type is... |
Ah, additionally, the tests were changed to use |
* Run test suite on windows-latest, macos-latest, ubuntu-latest * Fixed various issues related to temporary files on Windows * Add support for pathlib.Path to some functions missed in #93 * Fix loading remote yaml files on Windows Closes #80 Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Closes #82