Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying file format for visualization #85

Merged
merged 4 commits into from
Nov 26, 2021
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 24, 2021

So far, it was only possible to generate PNGs. This is still the default, but can be changed to any other format supported by matplotlib

dweindl and others added 2 commits November 24, 2021 16:52
So far, it was only possible to generate PNGs. This is still the default, but can be changed to any other format supported by matplotlib
@dweindl dweindl requested a review from plakrisenko November 25, 2021 09:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #85 (48dc5c8) into develop (918e1a4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
- Coverage    79.59%   79.57%   -0.02%     
===========================================
  Files           26       26              
  Lines         2940     2938       -2     
  Branches       695      695              
===========================================
- Hits          2340     2338       -2     
  Misses         423      423              
  Partials       177      177              
Impacted Files Coverage Δ
petab/visualize/plot_data_and_simulation.py 83.33% <100.00%> (-0.33%) ⬇️
petab/visualize/plotter.py 78.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918e1a4...48dc5c8. Read the comment docs.

@plakrisenko plakrisenko merged commit 22a9a0c into develop Nov 26, 2021
@dweindl dweindl deleted the vis_format branch November 26, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants