Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_required_parameters_for_parameter_table #43

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 19, 2021

Check that placeholder parameters are only considered as such for either observable or noise formula

Closes AMICI-dev/AMICI#1470

Check that placeholder parameters are only considered as such for either observable *or* noise formula

Closes AMICI-dev/AMICI#1470
@dweindl dweindl requested a review from FFroehlich March 19, 2021 13:56
@codecov-io
Copy link

Codecov Report

Merging #43 (7108366) into develop (6c46c00) will increase coverage by 0.10%.
The diff coverage is 85.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    78.52%   78.63%   +0.10%     
===========================================
  Files           24       24              
  Lines         2296     2307      +11     
  Branches       541      545       +4     
===========================================
+ Hits          1803     1814      +11     
  Misses         360      360              
  Partials       133      133              
Impacted Files Coverage Δ
petab/parameters.py 86.45% <50.00%> (+0.08%) ⬆️
petab/observables.py 97.10% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c46c00...7108366. Read the comment docs.

@dweindl dweindl merged commit a1d3d80 into develop Mar 19, 2021
@dweindl dweindl deleted the fix_get_required_parameters_for_parameter_table branch March 19, 2021 14:43
@dweindl dweindl mentioned this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants