Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve flatten overrides #42

Merged
merged 8 commits into from
Mar 19, 2021
Merged

improve flatten overrides #42

merged 8 commits into from
Mar 19, 2021

Conversation

FFroehlich
Copy link
Collaborator

No description provided.

@FFroehlich FFroehlich changed the title Update core.py improve flatten overrides Mar 18, 2021
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@b000937). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #42   +/-   ##
==========================================
  Coverage           ?   78.52%           
==========================================
  Files              ?       24           
  Lines              ?     2296           
  Branches           ?      541           
==========================================
  Hits               ?     1803           
  Misses             ?      360           
  Partials           ?      133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b000937...84aa6b9. Read the comment docs.

@dweindl dweindl self-requested a review March 19, 2021 09:46
dweindl
dweindl approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@FFroehlich FFroehlich merged commit 6c46c00 into develop Mar 19, 2021
@FFroehlich FFroehlich deleted the fix_flatten_overrides branch March 19, 2021 14:04
@dweindl dweindl mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FFroehlich @codecov-io @dweindl