Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create output directories in write_* #352

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Create output directories in write_* #352

merged 1 commit into from
Dec 20, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 20, 2024

No description provided.

@dweindl dweindl requested a review from a team as a code owner December 20, 2024 13:52
@dweindl dweindl marked this pull request as draft December 20, 2024 13:53
dilpath
dilpath approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏃💨

@dweindl dweindl marked this pull request as ready for review December 20, 2024 13:56
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.84%. Comparing base (6a9ecd0) to head (323c5a6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
petab/v1/core.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    74.82%   74.84%   +0.01%     
===========================================
  Files           56       56              
  Lines         5589     5597       +8     
  Branches       980      980              
===========================================
+ Hits          4182     4189       +7     
- Misses        1032     1033       +1     
  Partials       375      375

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl merged commit 6e762c6 into PEtab-dev:develop Dec 20, 2024
7 checks passed
@dweindl dweindl deleted the mkdir branch December 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilpath dilpath dilpath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweindl @codecov-commenter @dilpath