Make model id optional for PySBModel#318
Merged
dweindl merged 1 commit intoPEtab-dev:developfrom Nov 8, 2024
Merged
Conversation
If no ID is given, use `pysb.Model.name` as fallback. As is already the case for SbmlModel and its `id` attribute.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #318 +/- ##
===========================================
- Coverage 72.84% 72.81% -0.03%
===========================================
Files 52 52
Lines 4897 4900 +3
Branches 838 839 +1
===========================================
+ Hits 3567 3568 +1
- Misses 1025 1026 +1
- Partials 305 306 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no ID is given, use
pysb.Model.nameas fallback. As is already the case for SbmlModel and itsidattribute.