Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make model id optional for PySBModel #318

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 7, 2024

If no ID is given, use pysb.Model.name as fallback. As is already the case for SbmlModel and its id attribute.

If no ID is given, use `pysb.Model.name` as fallback. As is already the case for SbmlModel and its `id` attribute.
@dweindl dweindl requested a review from a team as a code owner November 7, 2024 10:23
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.81%. Comparing base (20f77f4) to head (87c253b).

Files with missing lines Patch % Lines
petab/v1/models/pysb_model.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #318      +/-   ##
===========================================
- Coverage    72.84%   72.81%   -0.03%     
===========================================
  Files           52       52              
  Lines         4897     4900       +3     
  Branches       838      839       +1     
===========================================
+ Hits          3567     3568       +1     
- Misses        1025     1026       +1     
- Partials       305      306       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl merged commit be3a5eb into PEtab-dev:develop Nov 8, 2024
7 checks passed
@dweindl dweindl deleted the optional_pysb_model_id branch November 8, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants