Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve column ordering in priors_to_measurements #317

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 6, 2024

Appending instead of preprending the new observables/measurements will preserve the column order.

Appending instead of preprending the new observables/measurements will preserve the column order.
@dweindl dweindl requested a review from a team as a code owner November 6, 2024 09:52
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.84%. Comparing base (ec5d036) to head (f0354d2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #317   +/-   ##
========================================
  Coverage    72.84%   72.84%           
========================================
  Files           52       52           
  Lines         4897     4897           
  Branches       838      838           
========================================
  Hits          3567     3567           
  Misses        1025     1025           
  Partials       305      305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl merged commit 20f77f4 into PEtab-dev:develop Nov 6, 2024
7 checks passed
@dweindl dweindl deleted the fix_priors_mes_col_order branch November 6, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants