Implement petab.* deprecation with __getattr__#297
Merged
Conversation
dweindl
reviewed
Jul 1, 2024
petab.Problem in favor of petab.v1.Problempetab.* deprecation with __getattr__
dilpath
commented
Jul 1, 2024
Member
Author
|
Should |
Member
I am undecided what we should import there. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #297 +/- ##
===========================================
+ Coverage 74.02% 74.49% +0.47%
===========================================
Files 73 46 -27
Lines 4800 4729 -71
Branches 1029 1034 +5
===========================================
- Hits 3553 3523 -30
+ Misses 953 908 -45
- Partials 294 298 +4 ☔ View full report in Codecov by Sentry. |
dweindl
approved these changes
Jul 1, 2024
Member
dweindl
left a comment
There was a problem hiding this comment.
Great, thanks. Let's get rid of that asap 🙈
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Jul 2, 2024
Fixes an issue introduced in PEtab-dev#297, which made all optional dependencies required.
Merged
dweindl
added a commit
that referenced
this pull request
Jul 2, 2024
Fixes an issue introduced in #297, which made all optional dependencies required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.