Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for remote files #287

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Fix validation for remote files #287

merged 5 commits into from
Jun 28, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 28, 2024

Actually load files instead of just checking exists, which failed on remote files.

Closes #286

@dweindl dweindl marked this pull request as ready for review June 28, 2024 09:17
@dweindl dweindl requested a review from a team as a code owner June 28, 2024 09:17
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.37%. Comparing base (6299139) to head (b96dbb8).

Files Patch % Lines
petab/v1/yaml.py 73.33% 3 Missing and 1 partial ⚠️
petab/v1/problem.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #287   +/-   ##
========================================
  Coverage    74.37%   74.37%           
========================================
  Files           70       70           
  Lines         4448     4460   +12     
  Branches       952      870   -82     
========================================
+ Hits          3308     3317    +9     
- Misses         869      872    +3     
  Partials       271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 6fff855 into PEtab-dev:develop Jun 28, 2024
7 checks passed
@dweindl dweindl deleted the fix_286 branch June 28, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants