Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add petab.v2.Problem #285

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Add petab.v2.Problem #285

merged 6 commits into from
Jun 28, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 28, 2024

Copy of v1.Problem with all deprecated functionality removed.

Loading PEtab 2.0 problems with petab.v1.Problem is now deprecated.

@dweindl dweindl marked this pull request as ready for review June 28, 2024 08:10
@dweindl dweindl requested a review from a team as a code owner June 28, 2024 08:10
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.96825% with 87 lines in your changes missing coverage. Please review.

Project coverage is 74.37%. Comparing base (721c0ed) to head (6dc222f).

Files Patch % Lines
petab/v2/problem.py 53.26% 80 Missing and 6 partials ⚠️
petab/v1/problem.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #285      +/-   ##
===========================================
- Coverage    75.25%   74.37%   -0.89%     
===========================================
  Files           69       70       +1     
  Lines         4260     4448     +188     
  Branches       900      952      +52     
===========================================
+ Hits          3206     3308     +102     
- Misses         789      869      +80     
- Partials       265      271       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 6299139 into PEtab-dev:develop Jun 28, 2024
7 checks passed
@dweindl dweindl deleted the problem_v2 branch June 28, 2024 08:40
@dilpath
Copy link
Member

dilpath commented Jul 5, 2024

Were to_files and to_files_generic deprecated / Is there a method to write a PEtab problem to disk, in petab.v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants