Skip to content

fix typo #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 3 commits into from
May 2, 2024
Merged

fix typo #257

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0cf2b4
fix typo
m-philipps Apr 30, 2024
dc1085d
Merge branch 'develop' into fix_typo
dweindl Apr 30, 2024
6658cd3
Merge branch 'develop' into fix_typo
m-philipps Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions petab/visualize/helper_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def create_dataset_id_list_new(

Parameters:
df: Measurements or simulations DataFrame.
group_by: Defines grouping of data to plot.
group_by: Defines grouping of data to plot.
id_list:
Grouping list. Each sublist corresponds to a subplot in a figure,
and contains the IDs of observables or simulation conditions for
Expand All @@ -73,9 +73,9 @@ def create_dataset_id_list_new(
dataset_id_list = []

if group_by == "simulation":
groupping_col = SIMULATION_CONDITION_ID
grouping_col = SIMULATION_CONDITION_ID
elif group_by == "observable":
groupping_col = OBSERVABLE_ID
grouping_col = OBSERVABLE_ID
if id_list is None:
# this is the default case. If no grouping is specified,
# all observables are plotted. One observable per plot.
Expand All @@ -88,7 +88,7 @@ def create_dataset_id_list_new(
plot_id_list = []
for cond_id in sublist:
plot_id_list.extend(
list(df[df[groupping_col] == cond_id][DATASET_ID].unique())
list(df[df[grouping_col] == cond_id][DATASET_ID].unique())
)
dataset_id_list.append(plot_id_list)
return dataset_id_list