Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Mar 6, 2024

No description provided.

dweindl and others added 3 commits January 29, 2024 16:01
Fixes

```
_________________ ERROR collecting tests/test_visualization.py _________________
tests/test_visualization.py:112: in <module>
    def visu_file_Fujita_empty():
.tox/unit/lib/python3.9/site-packages/_pytest/mark/structures.py:357: in __call__
    store_mark(func, self.mark)
.tox/unit/lib/python3.9/site-packages/_pytest/mark/structures.py:422: in store_mark
    warnings.warn(MARKED_FIXTURE, stacklevel=2)
E   pytest.PytestRemovedIn9Warning: Marks applied to fixtures have no effect
E   See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
```
#248)

So far, `SbmlModel.get_free_parameter_ids_with_values` ignored InitialAssignments,
resulting in incorrect parameter values in the parameter mapping.

Now the correct values are used in case of initial assignments that are parameter-independent, and parameters with other initial assignments are ignored.
@dweindl dweindl requested review from a team and m-philipps as code owners March 6, 2024 19:25
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 90379c4 into main Mar 6, 2024
@dweindl dweindl deleted the release_0.2.9 branch March 6, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants