Fix accessing preequilibrationConditionId without checking for presence #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in petab.visualize.data_overview.create_report which fails if there is no preequilibrationConditionId column in the measurements table.
Codecov Report
@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
- Coverage 76.24% 76.24% -0.01%
===========================================
Files 34 34
Lines 3183 3182 -1
Branches 773 773
===========================================
- Hits 2427 2426 -1
Misses 555 555
Partials 201 201
|
dilpath
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
👍
The old code assumes the existence of my_measurements[PREEQUILIBRATION_CONDITION_ID], so maybe this assumption is made elsewhere too and it's safer to create the PREEQUILIBRATION_CONDITION_ID key and fill it with dummy values here if it doesn't exist. I don't really know though, fine as is for me.
Yes. That would be something to consider throughout the library. Has been discussed before, but without any clear conclusion (e.g. #27). I will leave it as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in petab.visualize.data_overview.create_report which fails if there is no preequilibrationConditionId column in the measurements table.