Handle missing nominalValue in Problem.get_x_nominal #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #223 +/- ##
===========================================
+ Coverage 76.33% 76.35% +0.02%
===========================================
Files 34 34
Lines 3173 3176 +3
Branches 769 770 +1
===========================================
+ Hits 2422 2425 +3
Misses 552 552
Partials 199 199
|
dilpath
approved these changes
Jul 28, 2023
dweindl
added a commit
that referenced
this pull request
Sep 17, 2023
It doesn't seem to be quite clear if the `nominalValue` column needs to be present if all parameters are estimated. However, since it's allowed to leave `nominalValue` empty, which is treated as NaN, it seems to make sense to treat a missing `nominalValue` column as all-NaN. See also ICB-DCM/pyPESTO#1104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem to be quite clear if the
nominalValuecolumn needs to be present if all parameters are estimated.However, since it's allowed to leave
nominalValueempty, which is treated as NaN, it seems to make sense to treat a missingnominalValuecolumn as all-NaN.See also ICB-DCM/pyPESTO#1104