Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 26, 2023

Currently, there is no easy way to change figure sizes when using high-level visualization functions such as plot_problem.
Generally, I'd prefer controlling plotting through matplotlib's rcParams, but this change provides at least some backwards-compatible means of changing figure sizes at a higher level by, e.g. petab.visualize.plotting.DEFAULT_FIGSIZE = (8, 4).

Currently, there is no easy way to change figure sizes when using high-level visualization functions
such as `plot_problem`.
Generally, I'd prefer controlling plotting through matplotlib's `rcParams`, but this change provides
at least some backwards-compatible means of changing figure sizes at a higher level by, e.g.
`petab.visualize.plotting.DEFAULT_FIGSIZE = (8, 4)`.
@dweindl dweindl requested a review from plakrisenko as a code owner July 26, 2023 10:48
@codecov-commenter
Copy link

Codecov Report

Merging #222 (d4b5582) into develop (1aafa36) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #222   +/-   ##
========================================
  Coverage    76.32%   76.33%           
========================================
  Files           34       34           
  Lines         3172     3173    +1     
  Branches       769      769           
========================================
+ Hits          2421     2422    +1     
  Misses         552      552           
  Partials       199      199           
Files Changed Coverage Δ
petab/visualize/plotting.py 86.91% <100.00%> (+0.04%) ⬆️

@plakrisenko plakrisenko merged commit d9b1e65 into develop Jul 28, 2023
dweindl added a commit that referenced this pull request Sep 17, 2023
Currently, there is no easy way to change figure sizes when using high-level visualization functions
such as `plot_problem`.
Generally, I'd prefer controlling plotting through matplotlib's `rcParams`, but this change provides
at least some backwards-compatible means of changing figure sizes at a higher level by, e.g.
`petab.visualize.plotting.DEFAULT_FIGSIZE = (8, 4)`.
@dweindl dweindl deleted the figsize branch October 16, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants