Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing inplace=True in validation of visualization tables #214

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix missing inplace=True in validation of visualization tables #214

merged 1 commit into from
Jul 17, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 17, 2023

Closes #213

@dweindl dweindl requested a review from dilpath July 17, 2023 14:20
@dweindl dweindl requested a review from plakrisenko as a code owner July 17, 2023 14:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #214 (72c24f2) into develop (058bf1a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #214   +/-   ##
========================================
  Coverage    76.32%   76.32%           
========================================
  Files           34       34           
  Lines         3168     3168           
  Branches       768      768           
========================================
  Hits          2418     2418           
  Misses         552      552           
  Partials       198      198
Impacted Files Coverage Δ
petab/visualize/lint.py 51.42% <100.00%> (ø)

dilpath
dilpath approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dweindl dweindl merged commit 25ee7aa into develop Jul 17, 2023
@dweindl dweindl deleted the fix_213 branch July 17, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilpath dilpath dilpath approved these changes

@plakrisenko plakrisenko Awaiting requested review from plakrisenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweindl @codecov-commenter @dilpath