Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jun 24, 2023

No description provided.

dweindl and others added 5 commits June 20, 2023 19:44
The constructor has a default of `None`, which it handles by taking the ID attribute from the SBML model.
Test suite now completes without any distracting warnings. From now on, raise on warnings.
@dweindl dweindl requested a review from dilpath June 24, 2023 07:00
@dweindl dweindl requested review from a team and plakrisenko as code owners June 24, 2023 07:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2023

Codecov Report

Merging #211 (ef072dd) into main (ed44446) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   76.31%   76.32%   +0.01%     
==========================================
  Files          34       34              
  Lines        3162     3168       +6     
  Branches      765      768       +3     
==========================================
+ Hits         2413     2418       +5     
  Misses        552      552              
- Partials      197      198       +1     
Impacted Files Coverage Δ
petab/visualize/plotter.py 83.58% <83.33%> (-0.01%) ⬇️
petab/models/sbml_model.py 88.40% <100.00%> (ø)
petab/version.py 100.00% <100.00%> (ø)

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 058bf1a into main Jun 24, 2023
@dweindl dweindl deleted the 0.2.2 branch June 24, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants