Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented May 16, 2023

No description provided.

dweindl and others added 4 commits May 10, 2023 19:58
Incorrectly returned the parameter name, instead of its value.
* Fix Problem.to_files(model_file=...)

model_file parameter was not properly handled, resulting in missing model files in the created yaml file.

* typo

---------

Co-authored-by: dilpath <dilan.private+github@outlook.com>
@dweindl dweindl requested a review from a team as a code owner May 16, 2023 05:29
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #205 (ca4ab1f) into main (3c29fa1) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   76.31%   76.31%           
=======================================
  Files          34       34           
  Lines        3162     3162           
  Branches      765      765           
=======================================
  Hits         2413     2413           
  Misses        552      552           
  Partials      197      197           
Impacted Files Coverage Δ
petab/models/pysb_model.py 60.80% <0.00%> (ø)
petab/problem.py 64.51% <0.00%> (ø)
petab/version.py 100.00% <100.00%> (ø)

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit ed44446 into main May 16, 2023
@dweindl dweindl deleted the release_0.2.1 branch May 16, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants