Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method to unflatten simulation df produced by flattened PEtab problem #171

Merged
merged 10 commits into from
Aug 1, 2022
Merged

Method to unflatten simulation df produced by flattened PEtab problem #171

merged 10 commits into from
Aug 1, 2022

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Jul 28, 2022

No description provided.

@dilpath dilpath requested a review from dweindl July 28, 2022 15:46
dweindl
dweindl approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a test? Possibly extending test_petab.py::test_flatten_timepoint_specific_output_overrides

petab/core.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022 •
edited
Loading

Codecov Report

Merging #171 (662a10e) into develop (6c10c28) will increase coverage by 0.20%.
The diff coverage is 95.00%.

@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
+ Coverage    77.29%   77.50%   +0.20%     
===========================================
  Files           29       29              
  Lines         2577     2601      +24     
  Branches       591      594       +3     
===========================================
+ Hits          1992     2016      +24     
  Misses         430      430              
  Partials       155      155
Impacted Files Coverage Δ
petab/core.py 91.21% <95.00%> (+1.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

dweindl
dweindl reviewed Aug 1, 2022
View reviewed changes
petab/core.py Outdated Show resolved Hide resolved
dweindl
dweindl reviewed Aug 1, 2022
View reviewed changes
petab/core.py Outdated Show resolved Hide resolved
dweindl
dweindl reviewed Aug 1, 2022
View reviewed changes
petab/core.py Outdated Show resolved Hide resolved
dilpath and others added 3 commits August 1, 2022 08:54
@dilpath @dweindl
Apply suggestions from code review
a2e0b56 
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@dilpath
review: coherent naming
68f3968
@dilpath
review: test
662a10e
@dilpath dilpath merged commit 0ed3e0f into develop Aug 1, 2022
@dilpath dilpath deleted the unflatten_sim branch August 1, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dilpath @codecov-commenter @dweindl