Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for output parameters columns in the condition table #161

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 11, 2022

Parameters introduced via observableFormula or noiseFormula are allowed to occur as condition table columns. This was not handled correctly by petablint.

Parameters introduced via observableFormula or noiseFormula are only required in the parameter table if they are not already overridden for all conditions. This was not handled correctly by petablint.

@dweindl dweindl requested a review from dilpath July 11, 2022 13:59
@dweindl dweindl merged commit 9766f48 into develop Jul 11, 2022
@dweindl dweindl deleted the fix_output_par_condition_table branch July 11, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants