Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument forwarding for Problem.get_optimization_to_simulation_parameter_mapping #159

Merged
merged 4 commits into from
Jul 4, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 1, 2022

Previously, not all options relevant options of petab.get_optimization_to_simulation_parameter_mapping were accessible via Problem.get_optimization_to_simulation_parameter_mapping. Now all keyword arguments are forwarded.

…ter_mapping

Previously, not all options relevant options of `petab.get_optimization_to_simulation_parameter_mapping` were accesible via `Problem.get_optimization_to_simulation_parameter_mapping`. Now all keyword arguments are forwarded.
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #159 (81e7bda) into develop (201a32f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #159   +/-   ##
========================================
  Coverage    77.27%   77.27%           
========================================
  Files           29       29           
  Lines         2579     2579           
  Branches       594      594           
========================================
  Hits          1993     1993           
  Misses         430      430           
  Partials       156      156           
Impacted Files Coverage Δ
petab/problem.py 68.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201a32f...81e7bda. Read the comment docs.

@dweindl dweindl requested a review from dilpath July 1, 2022 20:57
petab/problem.py Outdated
):
"""
See get_simulation_to_optimization_parameter_mapping.
See :py:func:`get_simulation_to_optimization_parameter_mapping`, to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Looks like some names changed there...

@dweindl dweindl merged commit e892e31 into develop Jul 4, 2022
@dweindl dweindl deleted the par_map_fwd_args branch July 4, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants