Add support for PEtab problems with multiple condition files #152
Conversation
Allows specifying different conditions in different files. Closes #7
Codecov Report
@@ Coverage Diff @@
## develop #152 +/- ##
===========================================
+ Coverage 77.14% 77.39% +0.24%
===========================================
Files 26 26
Lines 2437 2437
Branches 579 579
===========================================
+ Hits 1880 1886 +6
Misses 404 404
+ Partials 153 147 -6
Continue to review full report at Codecov.
|
petab/problem.py
Outdated
| @@ -88,7 +88,8 @@ def __setstate__(self, state): | |||
| @staticmethod | |||
| def from_files( | |||
| sbml_file: Union[str, Path, None] = None, | |||
There was a problem hiding this comment.
| sbml_file: Union[str, Path, None] = None, | |
| sbml_file: Union[str, Path] = None, |
Not sure, why can sbml_file and condition_file be specified as None by the user, but not the other tables?
There was a problem hiding this comment.
All of them should be optional.
petab/problem.py
Outdated
| @@ -88,7 +88,8 @@ def __setstate__(self, state): | |||
| @staticmethod | |||
| def from_files( | |||
| sbml_file: Union[str, Path, None] = None, | |||
| condition_file: Union[str, Path, None] = None, | |||
| condition_file: | |||
| Union[str, Path, None, Iterable[Union[str, Path]]] = None, | |||
There was a problem hiding this comment.
Unrelated, but parameter_file can also be Iterable[Union[str, Path]] here, but is List[str] in get_parameter_df [1]. I guess it can be changed to Iterable[Union[str, Path]] at [1] too.
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Allows specifying different conditions in different files.
Closes #7