Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup visspec assembly / fix deprecation warning #135

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 28, 2022

  • Don't use deprecated pandas.DataFrame.append
  • Concatenate all at once

* Don't use deprecated pandas.DataFrame.append
* Concatenate all at once
@dweindl dweindl requested a review from plakrisenko April 28, 2022 12:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #135 (5892a80) into develop (3a0a218) will increase coverage by 0.01%.
The diff coverage is 84.61%.

@@             Coverage Diff             @@
##           develop     #135      +/-   ##
===========================================
+ Coverage    77.28%   77.30%   +0.01%     
===========================================
  Files           27       27              
  Lines         2959     2956       -3     
  Branches       724      724              
===========================================
- Hits          2287     2285       -2     
+ Misses         489      488       -1     
  Partials       183      183              
Impacted Files Coverage Δ
petab/visualize/plotting.py 86.00% <84.61%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0a218...5892a80. Read the comment docs.

@dweindl dweindl requested a review from dilpath April 28, 2022 13:38
@dweindl dweindl merged commit 93d7f60 into develop Apr 28, 2022
@dweindl dweindl deleted the fix_pd_deprecation branch April 28, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants