Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator: Report empty noiseFormula #134

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Validator: Report empty noiseFormula #134

merged 2 commits into from
Apr 28, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 28, 2022

Fixes #111

@dweindl dweindl requested a review from FFroehlich April 28, 2022 09:40
FFroehlich
FFroehlich approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #134 (57fd61d) into develop (902f349) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #134      +/-   ##
===========================================
+ Coverage    77.24%   77.28%   +0.04%     
===========================================
  Files           27       27              
  Lines         2957     2959       +2     
  Branches       723      724       +1     
===========================================
+ Hits          2284     2287       +3     
+ Misses         490      489       -1     
  Partials       183      183
Impacted Files Coverage Δ
petab/lint.py 67.85% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902f349...57fd61d. Read the comment docs.

@dweindl dweindl merged commit f701ee0 into develop Apr 28, 2022
@dweindl dweindl deleted the lint_missing_noise branch April 28, 2022 14:20
@dweindl dweindl linked an issue Apr 28, 2022 that may be closed by this pull request
empty noiseFormula is invalid but passes linting #111
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty noiseFormula is invalid but passes linting
3 participants
@dweindl @codecov-commenter @FFroehlich