Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions related to sbml-observables #131

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 27, 2022

Removes obsolete and deprecated functions from when observables were defined inside SBML models and when there was no observable table.

Removes obsolete and deprecated functions from when observables were defined inside SBML models and when there was no observable table.
@dweindl dweindl force-pushed the remove_deprecated_sbml_obs branch from 30fcfe3 to ad202a8 Compare April 27, 2022 22:04
@dweindl dweindl requested a review from FFroehlich April 27, 2022 22:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #131 (5323379) into develop (684c2c2) will increase coverage by 0.36%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #131      +/-   ##
===========================================
+ Coverage    76.87%   77.24%   +0.36%     
===========================================
  Files           27       27              
  Lines         3005     2957      -48     
  Branches       731      723       -8     
===========================================
- Hits          2310     2284      -26     
+ Misses         509      490      -19     
+ Partials       186      183       -3     
Impacted Files Coverage Δ
petab/measurements.py 90.12% <ø> (+10.12%) ⬆️
petab/problem.py 67.76% <ø> (+0.83%) ⬆️
petab/sbml.py 59.74% <100.00%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684c2c2...5323379. Read the comment docs.

@dweindl dweindl requested a review from dilpath April 28, 2022 13:39
Copy link
Collaborator

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 902f349 into develop Apr 28, 2022
@dweindl dweindl deleted the remove_deprecated_sbml_obs branch April 28, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants