Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit measurement processing if not relevant for parameter mapping #117

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

FFroehlich
Copy link
Collaborator

No description provided.

@FFroehlich
Copy link
Collaborator Author

massive speedup if number of conditions/measurements is large and no noise/observable parameters.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

petab/parameter_mapping.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #117 (fdd53f2) into develop (9d534f2) will decrease coverage by 0.06%.
The diff coverage is 57.14%.

@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
- Coverage    76.11%   76.04%   -0.07%     
===========================================
  Files           27       27              
  Lines         3023     3027       +4     
  Branches       733      736       +3     
===========================================
+ Hits          2301     2302       +1     
  Misses         537      537              
- Partials       185      188       +3     
Impacted Files Coverage Δ
petab/parameter_mapping.py 70.45% <57.14%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d534f2...fdd53f2. Read the comment docs.

Fabian Fröhlich and others added 2 commits March 25, 2022 14:33
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@FFroehlich FFroehlich merged commit 0512753 into develop Mar 25, 2022
@FFroehlich FFroehlich deleted the speedup branch March 25, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants