v2: Change parameter.estimate from 0/1 to true/false #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilpath
approved these changes
Mar 25, 2025
dweindl
commented
Mar 25, 2025
Meanwhile, boolean literals are supported in math expressions, so we should also use them for the boolean `estimate` column.
dweindl
force-pushed
the
v2_estimate_bool
branch
from
ea3ba29 to
f95ec67
Compare
FFroehlich
approved these changes
Mar 26, 2025
sebapersson
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meanwhile, boolean literals are supported in math expressions, so we should also use them for the boolean
estimatecolumn (see also #610).