-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ParameterScale sampler fixes #491 #492
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #492 +/- ##
========================================
Coverage 78.03% 78.03%
========================================
Files 23 23
Lines 2295 2295
Branches 544 544
========================================
Hits 1791 1791
Misses 369 369
Partials 135 135
Continue to review full report at Codecov.
|
Hey, sorry for not finishing this up before Christmas. It seems like @dilpath's bugfix was also the issue in this PR. I added a clarifying sentence in the documentation. To me, this should solve the problems. Are you fine with doing another small release (v.0.1.14), since this issue currently breaks pypesto initial value sampling in the develop branch? (I could take care of that, just want your OK :) ) |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Was unclear/wrong before.
Good to go unless @yannikschaelte or anybody else sees some problem there.
P.S.: Please add a proper pull request description. |
No description provided.