Skip to content

Clarification/specification of order of condition changes required #557

Open
@matthiaskoenig

Description

Depending on the order of the changes applied for a condition the model will be in a different state. I.e. the order of the columns matters in the condition table.
E.g. a model with species S in compartment C with an initial concentration of 1.0. If you change first the Volume C and then the initial concenctration [S0], the model has different values for [S0] compared to first changing concentration and then volume.

Currently it states

Row- and column-ordering are arbitrary, although specifying conditionId first may improve human readability.

This should be changed to:

Row- and column-ordering do not have any restrictions, although specifying conditionId first may improve human readability. The parameterOrSpeciesOrCompartmentIds changes for a condition are applied in order of the columns.

See also for instance: AMICI-dev/AMICI#2062

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions