Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear Documentation of noiseFormula #304

Closed
FFroehlich opened this issue Feb 18, 2020 · 2 comments
Closed

Unclear Documentation of noiseFormula #304

FFroehlich opened this issue Feb 18, 2020 · 2 comments
Assignees
Labels
bug Something isn't working fixed but not released fixed but not released

Comments

@FFroehlich
Copy link
Collaborator

FFroehlich commented Feb 18, 2020

Documentation of noiseFormula specified that its possible to specify numerical values here (conflicting with the type declaration as string), which doesn't seem to work (passing numerical values throws a mildly uninformative TypeError: expected string or bytes-like object error.)

Seems to be related to #264, but there is an issue with documentation nevertheless.

@dweindl
Copy link
Member

dweindl commented Feb 18, 2020

Okay, 'string' in this case also included e.g. '1.0'. But should be clarified. TypeError should not have occurred.

@dweindl dweindl added the bug Something isn't working label Feb 18, 2020
@FFroehlich
Copy link
Collaborator Author

FFroehlich commented Feb 18, 2020

Okay after fixing other parts of the petab specification I no longer get TyperErrors and both numerical and string variables seem to work. Documentation may still need clarification though.

@dweindl dweindl added this to the v0.1.3 milestone Feb 28, 2020
@dweindl dweindl self-assigned this Feb 28, 2020
@dweindl dweindl added the fixed but not released fixed but not released label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed but not released fixed but not released
Projects
None yet
Development

No branches or pull requests

2 participants