Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter file: Simplify prior specification #218

Closed
yannikschaelte opened this issue Jan 17, 2020 · 7 comments
Closed

Parameter file: Simplify prior specification #218

yannikschaelte opened this issue Jan 17, 2020 · 7 comments
Assignees

Comments

@yannikschaelte
Copy link
Member

Continuation of #17, see also #131, #206.

Currently, there are {priorX}, {initializationPriorX}, {objectivePriorX}, with X = {Type|Parameters}. The sole prior is supposed to simplify the setting when intitialization and objective prior coincide. However, this leads to unclear overwriting. Thus, it seems preferable to only keep initialization and objective, i.e. enforce defining both. While this creates some overhead when both coincide, it makes things clearer and less error-prone.

@yannikschaelte
Copy link
Member Author

@yannikschaelte yannikschaelte changed the title Parameter file: Simpliy prior specification Parameter file: Simplify prior specification Jan 17, 2020
@dweindl dweindl added this to the Release 0.0.3 milestone Jan 17, 2020
@yannikschaelte
Copy link
Member Author

alternatively, one could also drop objective... and only keep priorType and initializationPriorType, with the latter overwriting the priorType etc. when defined.

advantage: simplifies things in the (common) situation that both priors coincide, and no need to change existing stuff
disadvantage: the overwriting might be unintuitive.

@dweindl
Copy link
Member

dweindl commented Jan 19, 2020

I'd prefer explicit labels. Not sure if there are that many examples with priors yet that would have to be changed. Not feeling too strong about it though.

@yannikschaelte
Copy link
Member Author

I think most parameter files have empty 'priorType' and 'priorParameters' columns. Not much work to change though. @jvanhoefer you will use this. Any opinions?

@jvanhoefer
Copy link
Contributor

I have no strong feelings towards any of the solutions either...

@yannikschaelte
Copy link
Member Author

then we go for the explicit initialization+objective one.

@yannikschaelte
Copy link
Member Author

fixed in #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants