-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter file: Simplify prior specification #218
Comments
here is how the new specification would look: https://github.com/ICB-DCM/PEtab/blob/sampling/doc/documentation_data_format.md#detailed-field-description-1 |
alternatively, one could also drop objective... and only keep priorType and initializationPriorType, with the latter overwriting the priorType etc. when defined. advantage: simplifies things in the (common) situation that both priors coincide, and no need to change existing stuff |
I'd prefer explicit labels. Not sure if there are that many examples with priors yet that would have to be changed. Not feeling too strong about it though. |
I think most parameter files have empty 'priorType' and 'priorParameters' columns. Not much work to change though. @jvanhoefer you will use this. Any opinions? |
I have no strong feelings towards any of the solutions either... |
then we go for the explicit initialization+objective one. |
fixed in #222 |
Continuation of #17, see also #131, #206.
Currently, there are {priorX}, {initializationPriorX}, {objectivePriorX}, with X = {Type|Parameters}. The sole prior is supposed to simplify the setting when intitialization and objective prior coincide. However, this leads to unclear overwriting. Thus, it seems preferable to only keep initialization and objective, i.e. enforce defining both. While this creates some overhead when both coincide, it makes things clearer and less error-prone.
The text was updated successfully, but these errors were encountered: