Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prior definitions; add checks #222

Merged
merged 16 commits into from
Jan 20, 2020
Merged

Update prior definitions; add checks #222

merged 16 commits into from
Jan 20, 2020

Conversation

yannikschaelte
Copy link
Member

Fixes #218

@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #222 into develop will decrease coverage by 0.31%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #222      +/-   ##
==========================================
- Coverage    71.91%   71.6%   -0.32%     
==========================================
  Files           18      18              
  Lines         1517    1331     -186     
  Branches       377     302      -75     
==========================================
- Hits          1091     953     -138     
+ Misses         361     322      -39     
+ Partials        65      56       -9
Impacted Files Coverage Δ
petab/petablint.py 53.84% <0%> (-0.81%) ⬇️
petab/conditions.py 61.11% <100%> (+1.53%) ⬆️
petab/lint.py 54.82% <100%> (-4.51%) ⬇️
petab/core.py 91.66% <100%> (ø) ⬆️
petab/measurements.py 80.43% <100%> (-1.74%) ⬇️
petab/parameters.py 81.25% <100%> (-0.74%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918c934...fb976c3. Read the comment docs.

@yannikschaelte yannikschaelte self-assigned this Jan 17, 2020
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

doc/documentation_data_format.md Outdated Show resolved Hide resolved
doc/documentation_data_format.md Outdated Show resolved Hide resolved
@yannikschaelte
Copy link
Member Author

note: a check on the priorType column was added, but priorParameters is not checked yet.

@yannikschaelte
Copy link
Member Author

yannikschaelte commented Jan 19, 2020

currently, we write e.g. uniform -3;3 and parameterScaleUniform -3;3 assuming log10 parameters and bounds 1e-8, 1e8. It needs to be specified on what scale those priorParameters are. Would it make sense to have them on lin scale for uniform, and log10 scale for parameterScaleUniform?

@yannikschaelte yannikschaelte merged commit 9e4e2c5 into develop Jan 20, 2020
@yannikschaelte yannikschaelte deleted the sampling branch January 20, 2020 09:33
@yannikschaelte
Copy link
Member Author

currently, we write e.g. uniform -3;3 and parameterScaleUniform -3;3 assuming log10 parameters and bounds 1e-8, 1e8. It needs to be specified on what scale those priorParameters are. Would it make sense to have them on lin scale for uniform, and log10 scale for parameterScaleUniform?

done

@dweindl dweindl mentioned this pull request Jan 28, 2020
dweindl added a commit that referenced this pull request Jan 29, 2020
Release 0.1.0

Data format:

* Introduce observables table instead of SBML assignment rules for defining
  observation model (#244) (moves observableTransformation and noiseModel
  from the measurement table to the observables table)
* Allow initial concentrations / sizes in condition table (#238)
* Fixes and clarifications in the format documentation
* Changes in prior columns of the parameter table (#222)
* Introduced separate version number of file format, this release being
  version 1

Library:

* Adaptations to new file formats
* Various bugfixes and clean-up, especially in visualization and validator
* Parameter mapping changed to include all model parameters and not only
  those differing from the ones defined inside the SBML model
* Introduced constants for all field names and string options, replacing
  most string literals in the code (#228)
* Added unit tests and additional format validation steps
* Optional parallelization of parameter mapping (#205)
* Extended documentation (in-source and example Jupyter notebooks)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants